Thread (16 messages) 16 messages, 4 authors, 2020-08-03

RE: [PATCH 04/10] PCI: altera: Remove dev_err() when handing an error from platform_get_irq()

From: Tan, Ley Foon <hidden>
Date: 2020-08-03 06:21:17
Also in: linux-amlogic, linux-omap, linux-pci, linux-rockchip, linux-samsung-soc, linux-tegra

-----Original Message-----
From: Krzysztof Wilczyński <redacted>
Sent: Sunday, August 2, 2020 10:26 PM
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jingoo Han <jingoohan1@gmail.com>; Kukjin Kim <kgene@kernel.org>;
Krzysztof Kozlowski [off-list ref]; Richard Zhu
[off-list ref]; Lucas Stach [off-list ref]; Shawn
Guo [off-list ref]; Sascha Hauer [off-list ref];
Murali Karicheri [off-list ref]; Yue Wang
[off-list ref]; Kevin Hilman [off-list ref]; Thomas
Petazzoni [off-list ref]; Jesper Nilsson
[off-list ref]; Xiaowei Song [off-list ref];
Binghui Wang [off-list ref]; Pratyush Anand
[off-list ref]; Hou Zhiqiang [off-list ref];
Linus Walleij [off-list ref]; Toan Le
[off-list ref]; Tan, Ley Foon
[off-list ref]; Shawn Lin [off-list ref]; Heiko
Stuebner [off-list ref]; linux-amlogic@lists.infradead.org; linux-arm-
kernel@axis.com; linux-arm-kernel@lists.infradead.org; linux-
omap@vger.kernel.org; linux-pci@vger.kernel.org; linux-
rockchip@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
tegra@vger.kernel.org; rfi@lists.rocketboards.org
Subject: [PATCH 04/10] PCI: altera: Remove dev_err() when handing an error
from platform_get_irq()

There is no need to call the dev_err() function directly to print a custom
message when handling an error from either the platform_get_irq() or
platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/pcie-altera.c:717:2-9: line 717 is redundant
  because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <redacted>
---
Reviewed-by: Ley Foon Tan <redacted>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help