Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration
From: Arnd Bergmann <arnd@arndb.de>
Date: 2020-08-12 09:15:06
Also in:
linux-clk, linux-samsung-soc, linux-watchdog
On Wed, Aug 12, 2020 at 9:59 AM Stephen Boyd [off-list ref] wrote:
Quoting Krzysztof Kozlowski (2020-08-04 12:26:54)quoted
The s3c_camif_gpio_put() declaration in include/media/drv-intf/s3c_camif.h header was different than definition. Fixing this allows to include that header to also fix the W=1 compile warnings: arch/arm/mach-s3c24xx/setup-camif.c:28:5: warning: no previous prototype for 's3c_camif_gpio_get' [-Wmissing-prototypes] 28 | int s3c_camif_gpio_get(void) arch/arm/mach-s3c24xx/setup-camif.c:56:6: warning: no previous prototype for 's3c_camif_gpio_put' [-Wmissing-prototypes] 56 | void s3c_camif_gpio_put(void)Maybe it should have been void all along?
It seems there have never been any callers and the entire file
can just be removed, with the rest of that platform_data header
file moved to drivers/media/platform/s3c-camif/.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel