Re: [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in Exynos5433 TM2
From: Marek Szyprowski <m.szyprowski@samsung.com>
Date: 2020-08-31 13:13:30
Also in:
alsa-devel, dri-devel, linux-devicetree, linux-samsung-soc, lkml
On 29.08.2020 16:25, Krzysztof Kozlowski wrote:
The Wolfson Arizona codec is interrupt controller which is required by bindings. This fixes dtbs_check warnings like: arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: 'interrupt-controller' is a required property arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: '#interrupt-cells' is a required property Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> However I really wonder if it makes sense to expose this to DTS. Indeed, the main MFD device of the WM5110 chip is interrupt controller, but its interrupts are requested internally by the respective drivers.
quoted hunk ↗ jump to hunk
--- Not tested on HQ. Please kindly review and test. Best regards, Krzysztof --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 ++ 1 file changed, 2 insertions(+)diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index bab6c1addd5f..49cd55d6891c 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi@@ -1242,6 +1242,8 @@ gpio-controller; #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; wlf,micd-detect-debounce = <300>; wlf,micd-bias-start-time = <0x1>;
Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel