[PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars

Subsystems: arm/amlogic meson soc support, multimedia card (mmc), secure digital (sd) and sdio subsystem, the rest

STALE2160d LANDED

Landed in mainline as e0c29be62cdc on 2020-09-07.

3 messages, 3 authors, 2020-09-02 · open the first message on its own page

[PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars

From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date: 2020-08-31 10:23:37 

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Only buildtested. Found while analyzing retune-handling in the core.

 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 08a3b1c05acb..a1db8685e30e 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
 	val |= ADJUST_ADJ_EN;
 	writel(val, host->regs + host->data->adjust);
 
-	if (mmc->doing_retune)
+	if (mmc_doing_retune(mmc))
 		dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
 	else
 		dly = 0;
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars

From: Kevin Hilman <khilman@baylibre.com>
Date: 2020-08-31 18:35:46 

Wolfram Sang [off-list ref] writes:

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
quoted hunk
---

Only buildtested. Found while analyzing retune-handling in the core.

 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 08a3b1c05acb..a1db8685e30e 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
 	val |= ADJUST_ADJ_EN;
 	writel(val, host->regs + host->data->adjust);
 
-	if (mmc->doing_retune)
+	if (mmc_doing_retune(mmc))
 		dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
 	else
 		dly = 0;
-- 
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars

From: Ulf Hansson <hidden>
Date: 2020-09-02 09:04:28 

On Mon, 31 Aug 2020 at 12:23, Wolfram Sang
[off-list ref] wrote:
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied for next, thanks!

Kind regards
Uffe
quoted hunk
---

Only buildtested. Found while analyzing retune-handling in the core.

 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 08a3b1c05acb..a1db8685e30e 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -521,7 +521,7 @@ static int meson_mmc_resampling_tuning(struct mmc_host *mmc, u32 opcode)
        val |= ADJUST_ADJ_EN;
        writel(val, host->regs + host->data->adjust);

-       if (mmc->doing_retune)
+       if (mmc_doing_retune(mmc))
                dly = FIELD_GET(ADJUST_ADJ_DELAY_MASK, val) + 1;
        else
                dly = 0;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help