Re: [PATCH v2 9/9] perf: Remove x86 specific rdpmc test
From: Jiri Olsa <hidden>
Date: 2020-08-31 09:11:28
Also in:
lkml
On Fri, Aug 28, 2020 at 02:56:14PM -0600, Rob Herring wrote:
quoted hunk ↗ jump to hunk
Now that we have a common libperf based userspace counter read test with the same functionality as the x86 specific rdpmc test, let's remove it. Signed-off-by: Rob Herring <robh@kernel.org> --- This one is optional. On the plus side, it eliminates a copy of the read loop. The main downside I see is loosing the ability to test in 'perf test'. tools/perf/arch/x86/include/arch-tests.h | 1 - tools/perf/arch/x86/tests/Build | 1 - tools/perf/arch/x86/tests/arch-tests.c | 4 - tools/perf/arch/x86/tests/rdpmc.c | 182 ----------------------- 4 files changed, 188 deletions(-) delete mode 100644 tools/perf/arch/x86/tests/rdpmc.cdiff --git a/tools/perf/arch/x86/include/arch-tests.h b/tools/perf/arch/x86/include/arch-tests.h index c41c5affe4be..d9c32ba0cdac 100644 --- a/tools/perf/arch/x86/include/arch-tests.h +++ b/tools/perf/arch/x86/include/arch-tests.h@@ -6,7 +6,6 @@ struct test; /* Tests */ -int test__rdpmc(struct test *test __maybe_unused, int subtest);
we don't currently run libperf tests as part of perf test suite, so before we do that, I rather not remove the tests.. feel free to add the code that runs libperf tests within 'perf test' command ;-) thanks, jirka _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel