Re: [PATCH] clk: versatile: Add of_node_put() before return statement
From: Linus Walleij <hidden>
Date: 2020-08-30 10:07:38
Also in:
linux-clk, lkml
From: Linus Walleij <hidden>
Date: 2020-08-30 10:07:38
Also in:
linux-clk, lkml
On Sat, Aug 29, 2020 at 7:57 PM Sumera Priyadarsini [off-list ref] wrote:
Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak. Fix a potential memory leak in clk-impd1.c by inserting of_node_put() before a return statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini <redacted>
Reviewed-by: Linus Walleij <redacted> Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel