Re: [PATCH] maiblox: mediatek: Fix handling of platform_get_irq() error
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2020-08-27 07:29:16
Also in:
linux-mediatek, lkml
On Thu, 27 Aug 2020 at 09:26, Krzysztof Kozlowski [off-list ref] wrote:
quoted hunk ↗ jump to hunk
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check. Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver") Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 484d4438cd83..76e4dfcf5228 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c@@ -525,10 +525,8 @@ static int cmdq_probe(struct platform_device *pdev) } cmdq->irq = platform_get_irq(pdev, 0); - if (!cmdq->irq) { - dev_err(dev, "failed to get irq\n"); - return -EINVAL; - } + if (!cmdq->irq < 0)
Ah, this is wrong. The irq is u32... without my patch this was so broken... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel