Re: [PATCH 1/2] usb typec: mt6360: Add support for mt6360 Type-C driver
From: Guenter Roeck <linux@roeck-us.net>
Date: 2020-08-27 01:02:51
Also in:
linux-devicetree, linux-mediatek, linux-usb, lkml
On 8/26/20 5:59 PM, 啟原黃 wrote: [ ... ]
quoted
quoted
+static int mt6360_tcpc_remove(struct platform_device *pdev) +{ + struct mt6360_tcpc_info *mti = platform_get_drvdata(pdev); + + tcpci_unregister_port(mti->tcpci);That leaves interrupts enabled, which might be racy because interrupts are still enabled here.M..., yes, it will cause the race condition during module remove. I'll add disable_irq before tcpci unregister to prevent it.
Or just set TCPC_ALERT_MASK to 0, as in tcpci.c. Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel