Thread (5 messages) 5 messages, 4 authors, 2020-08-21

Re: [Patch] cpufreq: replace cpu_logical_map with read_cpuid_mpir

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2020-08-21 18:18:25
Also in: linux-pm, linux-tegra, lkml

On Fri, Aug 21, 2020 at 7:22 AM Viresh Kumar [off-list ref] wrote:
On 20-08-20, 13:37, Sudeep Holla wrote:
quoted
On Thu, Aug 20, 2020 at 11:09:45AM +0530, Viresh Kumar wrote:
quoted
On 12-08-20, 01:13, Sumit Gupta wrote:
quoted
Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue")
fixes the issue with building tegra194 cpufreq driver as module. But
the fix might cause problem while supporting physical cpu hotplug[1].

This patch fixes the original problem by avoiding use of cpu_logical_map().
Instead calling read_cpuid_mpidr() to get MPIDR on target cpu.

[1] https://lore.kernel.org/linux-arm-kernel/20200724131059.GB6521@bogus/ (local)

Reviewed-by: Sudeep Holla <redacted>
Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
---
 drivers/cpufreq/tegra194-cpufreq.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
Applied. Thanks.
Just to confirm, is this going as a fix ? We want to drop exporting
cpu_logical_map in v5.9 so this needs to go as fix. I missed it earlier,
actually,

Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver")
is appropriate here so that we can drop export symbol which was part of
Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue")
as a workaround to  fix the build.
Okay.

Rafael: Please pick this patch directly for next rc with

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied as 5.9-rc3 material with a couple of minor edits in the
subject and changelog, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help