Hi Martin,

This looks good.

Only some minor comments:

On Fri, Jul 31, 2020 at 5:28 AM Martin Kepplinger
[off-list ref] wrote:

+       sound {
+               compatible = "simple-audio-card";
+               pinctrl-0 = <&pinctrl_hp>;

Please pass pinctrl-names = "default"; prior to pinctrl-0. Please
check globally in this patch.

+&ecspi1 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_ecspi1>;
+       cs-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>;

This should be active low instead.

After 8cdcd8aeee28 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors")
you should a similar message as in the kernel log:

flash@0 enforce active low on chipselect handle

+       pinctrl_ecspi1: spi1grp {

ecspigrp {

+       flash@53 {
+               compatible = "lm3560";

This seems to be not documented. It also misses the vendor.

+&i2c3 {
+       clock-frequency = <387000>;
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_i2c3>;
+       status = "okay";
+
+       codec: audio-codec@1a {
+               compatible = "wlf,wm8962";
+               reg = <0x1a>; // 0x4a is the test address

Remove the comment, maybe?

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel