Re: [PATCH 2/4] ARM: backtrace-clang: add fixup for lr dereference
From: Nick Desaulniers <ndesaulniers@google.com>
Date: 2020-08-20 00:14:09
Also in:
linux-mediatek, lkml, stable
From: Nick Desaulniers <ndesaulniers@google.com>
Date: 2020-08-20 00:14:09
Also in:
linux-mediatek, lkml, stable
On Mon, Aug 10, 2020 at 3:33 PM Nick Desaulniers [off-list ref] wrote:
On Thu, Aug 6, 2020 at 3:39 PM Nathan Huckleberry [off-list ref] wrote:quoted
Mostly looks good to me. Just a minor nit. On Thu, Jul 30, 2020 at 3:51 PM Nick Desaulniers [off-list ref] wrote:quoted
+/* + * Accessing the address pointed to by the link register triggered an + * exception, don't try to unwind through it. + */ +bad_lr: mov sv_fp, #0It might be nice to emit a warning here since we'll only hit this case if something fishy is going on with the saved lr.Yeah, something fishy is going on if that ever happens. Let me create a V2 with an additional print.
FWIW, I ran into another bug on -next when trying to update this. Report: https://lore.kernel.org/lkml/20200811204729.1116341-1-ndesaulniers@google.com/ (local) Fix: https://lore.kernel.org/lkml/20200814212525.6118-1-john.ogness@linutronix.de/T/#t (local) Then I got bogged down in planning for plumbers and other fires. I hope to revisit the series after plumbers. -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel