Thread (28 messages) 28 messages, 4 authors, 2020-09-09

Re: [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701

From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2020-08-19 17:12:59
Also in: dri-devel, linux-mediatek, lkml


On 19/08/2020 10:17, Frank Wunderlich wrote:
From: chunhui dai <redacted>

disable tmds on phy on mt2701 to support other resolutions like 1280x1024
Isn't that worth a Fixes tag?

Regards,
Matthias
quoted hunk ↗ jump to hunk
Signed-off-by: chunhui dai <redacted>
Signed-off-by: Frank Wunderlich <redacted>
Tested-by: Frank Wunderlich <redacted>
---
  drivers/gpu/drm/mediatek/mtk_hdmi_phy.c        | 3 +++
  drivers/gpu/drm/mediatek/mtk_hdmi_phy.h        | 1 +
  drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c | 1 +
  3 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c
index 5223498502c4..edadb7a700f1 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c
@@ -184,6 +184,9 @@ static int mtk_hdmi_phy_probe(struct platform_device *pdev)
  		return PTR_ERR(phy_provider);
  	}
  
+	if (hdmi_phy->conf->pll_default_off)
+		hdmi_phy->conf->hdmi_phy_disable_tmds(hdmi_phy);
+
  	return of_clk_add_provider(dev->of_node, of_clk_src_simple_get,
  				   hdmi_phy->pll);
  }
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h
index 2d8b3182470d..f472fdeb63dc 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h
@@ -22,6 +22,7 @@ struct mtk_hdmi_phy;
  struct mtk_hdmi_phy_conf {
  	bool tz_disabled;
  	unsigned long flags;
+	bool pll_default_off;
  	const struct clk_ops *hdmi_phy_clk_ops;
  	void (*hdmi_phy_enable_tmds)(struct mtk_hdmi_phy *hdmi_phy);
  	void (*hdmi_phy_disable_tmds)(struct mtk_hdmi_phy *hdmi_phy);
diff --git a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c
index d3cc4022e988..6fbedacfc1e8 100644
--- a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c
+++ b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c
@@ -239,6 +239,7 @@ static void mtk_hdmi_phy_disable_tmds(struct mtk_hdmi_phy *hdmi_phy)
  struct mtk_hdmi_phy_conf mtk_hdmi_phy_2701_conf = {
  	.tz_disabled = true,
  	.flags = CLK_SET_RATE_GATE,
+	.pll_default_off = true,
  	.hdmi_phy_clk_ops = &mtk_hdmi_phy_pll_ops,
  	.hdmi_phy_enable_tmds = mtk_hdmi_phy_enable_tmds,
  	.hdmi_phy_disable_tmds = mtk_hdmi_phy_disable_tmds,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help