Re: [PATCH 6/8] spi: spi-s3c64xx: Check return values
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2020-08-19 16:14:06
Also in:
linux-samsung-soc, linux-spi, lkml
On Wed, Aug 19, 2020 at 05:41:43PM +0200, Lukasz Stelmach wrote:
It was <2020-08-19 śro 14:48>, when Krzysztof Kozlowski wrote:quoted
On Wed, Aug 19, 2020 at 02:32:06PM +0200, Łukasz Stelmach wrote:quoted
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com> --- drivers/spi/spi-s3c64xx.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)Oh, come on, stop fixing the same local issue without fixing bigger picture... or at least documenting why bigger picture does not have to be fixed and simple 'return' is enough. That's the third, same fix for the same problem. https://lore.kernel.org/lkml/20190314064202.14864-1-kjlu@umn.edu/ (local) https://lore.kernel.org/lkml/20170207204520.h2eo3yn5kge56lk7@kozik-lap/ (local)No wonder. There is a possible NULL dereference below. Now at least we know something about conditions that led to this. Should I drop the entire patch, or just the dmaengine_prep_slave_sg() part?
The best would be to really go through the call stack and handle the error properly. This means returning an error code and propagating it further. It is not a trivial change... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel