Re: [PATCH 7/8] spi: spi-s3c64xx: Increase transfer timeout
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2020-08-19 12:49:47
Also in:
linux-samsung-soc, linux-spi, lkml
Possibly related (same subject, not in this thread)
- 2020-08-21 · Re: [PATCH 7/8] spi: spi-s3c64xx: Increase transfer timeout · Krzysztof Kozlowski <krzk@kernel.org>
- 2020-08-19 · Re: [PATCH 7/8] spi: spi-s3c64xx: Increase transfer timeout · Lukasz Stelmach <l.stelmach@samsung.com>
On Wed, Aug 19, 2020 at 02:32:07PM +0200, Łukasz Stelmach wrote:
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
Why? Everything works fine and suddenly minimum timeout is 100 ms? Best regards, Krzysztof
quoted hunk ↗ jump to hunk
--- drivers/spi/spi-s3c64xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 27d77600a820..27db1e0f6f32 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c@@ -464,7 +464,8 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd, /* millisecs to xfer 'len' bytes @ 'cur_speed' */ ms = xfer->len * 8 * 1000 / sdd->cur_speed; - ms += 10; /* some tolerance */ + ms = (ms * 10) + 30; /* some tolerance */ + ms = max(ms, 100); /* minimum timeout */ val = msecs_to_jiffies(ms) + 10; val = wait_for_completion_timeout(&sdd->xfer_completion, val);-- 2.26.2
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel