From: Al Grant <redacted>
Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
changed the format of branch stacks in perf samples. When samples use
this new format, a flag must be set in the corresponding event.
Synthesized branch stacks generated from CoreSight ETM trace were using
the new format, but not setting the event attribute, leading to
consumers seeing corrupt data. This patch fixes the issue by setting the
event attribute to indicate use of the new format.
Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
Signed-off-by: Al Grant <redacted>
Reviewed-by: Andrea Brunato <redacted>
Signed-off-by: Leo Yan <redacted>
---
tools/perf/util/cs-etm.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
From: Al Grant <redacted>
Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
changed the format of branch stacks in perf samples. When samples use
this new format, a flag must be set in the corresponding event.
Synthesized branch stacks generated from Intel PT were using the new
format, but not setting the event attribute, leading to consumers
seeing corrupt data. This patch fixes the issue by setting the event
attribute to indicate use of the new format.
Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
Signed-off-by: Al Grant <redacted>
Signed-off-by: Leo Yan <redacted>
---
tools/perf/util/intel-pt.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
From: Adrian Hunter <adrian.hunter@intel.com> Date: 2020-08-24 12:42:00
On 19/08/20 11:47 am, Leo Yan wrote:
From: Al Grant <redacted>
Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
changed the format of branch stacks in perf samples. When samples use
this new format, a flag must be set in the corresponding event.
Synthesized branch stacks generated from Intel PT were using the new
format, but not setting the event attribute, leading to consumers
seeing corrupt data. This patch fixes the issue by setting the event
attribute to indicate use of the new format.
Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
Signed-off-by: Al Grant <redacted>
Signed-off-by: Leo Yan <redacted>
Hi Leo and Al,
On Wed, Aug 19, 2020 at 04:47:50PM +0800, Leo Yan wrote:
quoted hunk
From: Al Grant <redacted>
Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
changed the format of branch stacks in perf samples. When samples use
this new format, a flag must be set in the corresponding event.
Synthesized branch stacks generated from CoreSight ETM trace were using
the new format, but not setting the event attribute, leading to
consumers seeing corrupt data. This patch fixes the issue by setting the
event attribute to indicate use of the new format.
Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
Signed-off-by: Al Grant <redacted>
Reviewed-by: Andrea Brunato <redacted>
Signed-off-by: Leo Yan <redacted>
---
tools/perf/util/cs-etm.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
Hi Mathieu,
On Thu, Aug 27, 2020 at 02:53:54PM -0600, Mathieu Poirier wrote:
Hi Leo and Al,
On Wed, Aug 19, 2020 at 04:47:50PM +0800, Leo Yan wrote:
quoted
From: Al Grant <redacted>
Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
changed the format of branch stacks in perf samples. When samples use
this new format, a flag must be set in the corresponding event.
Synthesized branch stacks generated from CoreSight ETM trace were using
the new format, but not setting the event attribute, leading to
consumers seeing corrupt data. This patch fixes the issue by setting the
event attribute to indicate use of the new format.
Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
Signed-off-by: Al Grant <redacted>
Reviewed-by: Andrea Brunato <redacted>
Signed-off-by: Leo Yan <redacted>
---
tools/perf/util/cs-etm.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
@@ -1344,8 +1344,15 @@ static int cs_etm__synth_events(struct cs_etm_auxtrace *etm,attr.sample_type&=~(u64)PERF_SAMPLE_ADDR;}-if(etm->synth_opts.last_branch)+if(etm->synth_opts.last_branch){attr.sample_type|=PERF_SAMPLE_BRANCH_STACK;+/*+*Wedon'tusethehardwareindex,butthesamplegeneration+*codeusesthenewformatbranch_stackwiththisfield,+*sotheeventattributesmustindicatethatit'spresent.+*/+attr.branch_sample_type|=PERF_SAMPLE_BRANCH_HW_INDEX;+}
I've see this patch before... I thought it had been merged - what happened?
This patch before has been sent by Al to CoreSight mailing list but has
not sent to LKML, this is why I resent it to LKML in case it's missed.
Thanks,
Leo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Wed, Aug 19, 2020 at 04:47:51PM +0800, Leo Yan wrote:
From: Al Grant <redacted>
Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
changed the format of branch stacks in perf samples. When samples use
this new format, a flag must be set in the corresponding event.
Synthesized branch stacks generated from Intel PT were using the new
format, but not setting the event attribute, leading to consumers
seeing corrupt data. This patch fixes the issue by setting the event
attribute to indicate use of the new format.
Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
Signed-off-by: Al Grant <redacted>
Signed-off-by: Leo Yan <redacted>
From: Arnaldo Carvalho de Melo <acme@kernel.org> Date: 2020-09-01 14:53:45
Em Mon, Aug 31, 2020 at 02:38:32PM -0600, Mathieu Poirier escreveu:
On Wed, Aug 19, 2020 at 04:47:51PM +0800, Leo Yan wrote:
quoted
From: Al Grant <redacted>
Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
changed the format of branch stacks in perf samples. When samples use
this new format, a flag must be set in the corresponding event.
Synthesized branch stacks generated from Intel PT were using the new
format, but not setting the event attribute, leading to consumers
seeing corrupt data. This patch fixes the issue by setting the event
attribute to indicate use of the new format.
Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
Signed-off-by: Al Grant <redacted>
Signed-off-by: Leo Yan <redacted>
From: Arnaldo Carvalho de Melo <acme@kernel.org> Date: 2020-09-01 14:55:00
Em Mon, Aug 31, 2020 at 08:04:32AM +0800, Leo Yan escreveu:
Hi Mathieu,
On Thu, Aug 27, 2020 at 02:53:54PM -0600, Mathieu Poirier wrote:
quoted
Hi Leo and Al,
On Wed, Aug 19, 2020 at 04:47:50PM +0800, Leo Yan wrote:
quoted
From: Al Grant <redacted>
Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
changed the format of branch stacks in perf samples. When samples use
this new format, a flag must be set in the corresponding event.
Synthesized branch stacks generated from CoreSight ETM trace were using
the new format, but not setting the event attribute, leading to
consumers seeing corrupt data. This patch fixes the issue by setting the
event attribute to indicate use of the new format.
Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
Signed-off-by: Al Grant <redacted>
Reviewed-by: Andrea Brunato <redacted>
Signed-off-by: Leo Yan <redacted>
---
tools/perf/util/cs-etm.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
@@ -1344,8 +1344,15 @@ static int cs_etm__synth_events(struct cs_etm_auxtrace *etm,attr.sample_type&=~(u64)PERF_SAMPLE_ADDR;}-if(etm->synth_opts.last_branch)+if(etm->synth_opts.last_branch){attr.sample_type|=PERF_SAMPLE_BRANCH_STACK;+/*+*Wedon'tusethehardwareindex,butthesamplegeneration+*codeusesthenewformatbranch_stackwiththisfield,+*sotheeventattributesmustindicatethatit'spresent.+*/+attr.branch_sample_type|=PERF_SAMPLE_BRANCH_HW_INDEX;+}
I've see this patch before... I thought it had been merged - what happened?
This patch before has been sent by Al to CoreSight mailing list but has
not sent to LKML, this is why I resent it to LKML in case it's missed.
So, was it Acked on the CoreSight mailing list? Are we missing any
Acked-by or Reviewed-by for this 1/2 patch as we got for 2/2?
- Arnaldo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Arnaldo,
On Tue, Sep 01, 2020 at 11:54:32AM -0300, Arnaldo Carvalho de Melo wrote:
Em Mon, Aug 31, 2020 at 08:04:32AM +0800, Leo Yan escreveu:
quoted
Hi Mathieu,
On Thu, Aug 27, 2020 at 02:53:54PM -0600, Mathieu Poirier wrote:
quoted
Hi Leo and Al,
On Wed, Aug 19, 2020 at 04:47:50PM +0800, Leo Yan wrote:
quoted
From: Al Grant <redacted>
Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
changed the format of branch stacks in perf samples. When samples use
this new format, a flag must be set in the corresponding event.
Synthesized branch stacks generated from CoreSight ETM trace were using
the new format, but not setting the event attribute, leading to
consumers seeing corrupt data. This patch fixes the issue by setting the
event attribute to indicate use of the new format.
Fixes: 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack")
Signed-off-by: Al Grant <redacted>
Reviewed-by: Andrea Brunato <redacted>
Signed-off-by: Leo Yan <redacted>
---
tools/perf/util/cs-etm.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
@@ -1344,8 +1344,15 @@ static int cs_etm__synth_events(struct cs_etm_auxtrace *etm,attr.sample_type&=~(u64)PERF_SAMPLE_ADDR;}-if(etm->synth_opts.last_branch)+if(etm->synth_opts.last_branch){attr.sample_type|=PERF_SAMPLE_BRANCH_STACK;+/*+*Wedon'tusethehardwareindex,butthesamplegeneration+*codeusesthenewformatbranch_stackwiththisfield,+*sotheeventattributesmustindicatethatit'spresent.+*/+attr.branch_sample_type|=PERF_SAMPLE_BRANCH_HW_INDEX;+}
I've see this patch before... I thought it had been merged - what happened?
This patch before has been sent by Al to CoreSight mailing list but has
not sent to LKML, this is why I resent it to LKML in case it's missed.
So, was it Acked on the CoreSight mailing list? Are we missing any
Acked-by or Reviewed-by for this 1/2 patch as we got for 2/2?
The CoreSight mailing list has some discussion for this patch set,
when respin this patch set, I confirmed we don't miss any 'Acked' or
'Reviewed' tags.
Thanks,
Leo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Arnaldo Carvalho de Melo <acme@kernel.org> Date: 2020-09-02 01:49:18
Em Wed, Sep 02, 2020 at 08:39:32AM +0800, Leo Yan escreveu:
On Tue, Sep 01, 2020 at 11:54:32AM -0300, Arnaldo Carvalho de Melo wrote:
quoted
Em Mon, Aug 31, 2020 at 08:04:32AM +0800, Leo Yan escreveu:
quoted
On Thu, Aug 27, 2020 at 02:53:54PM -0600, Mathieu Poirier wrote:
quoted
On Wed, Aug 19, 2020 at 04:47:50PM +0800, Leo Yan wrote:
I've see this patch before... I thought it had been merged - what happened?
quoted
quoted
This patch before has been sent by Al to CoreSight mailing list but has
not sent to LKML, this is why I resent it to LKML in case it's missed.
quoted
So, was it Acked on the CoreSight mailing list? Are we missing any
Acked-by or Reviewed-by for this 1/2 patch as we got for 2/2?
The CoreSight mailing list has some discussion for this patch set,
when respin this patch set, I confirmed we don't miss any 'Acked' or
'Reviewed' tags.
So, this patch was included in today's
perf-tools-fixes-for-v5.9-2020-09-01 signed tag sent to Linus in a pull
req, please update your perf/urgent branch, and go on from there, I'll
merge that into my perf/core branch as soon as Linus merges it.
- Arnaldo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Sep 01, 2020 at 10:47:54PM -0300, Arnaldo Carvalho de Melo wrote:
Em Wed, Sep 02, 2020 at 08:39:32AM +0800, Leo Yan escreveu:
quoted
On Tue, Sep 01, 2020 at 11:54:32AM -0300, Arnaldo Carvalho de Melo wrote:
quoted
Em Mon, Aug 31, 2020 at 08:04:32AM +0800, Leo Yan escreveu:
quoted
On Thu, Aug 27, 2020 at 02:53:54PM -0600, Mathieu Poirier wrote:
quoted
On Wed, Aug 19, 2020 at 04:47:50PM +0800, Leo Yan wrote:
I've see this patch before... I thought it had been merged - what happened?
quoted
quoted
quoted
This patch before has been sent by Al to CoreSight mailing list but has
not sent to LKML, this is why I resent it to LKML in case it's missed.
quoted
quoted
So, was it Acked on the CoreSight mailing list? Are we missing any
Acked-by or Reviewed-by for this 1/2 patch as we got for 2/2?
quoted
The CoreSight mailing list has some discussion for this patch set,
when respin this patch set, I confirmed we don't miss any 'Acked' or
'Reviewed' tags.
So, this patch was included in today's
perf-tools-fixes-for-v5.9-2020-09-01 signed tag sent to Linus in a pull
req, please update your perf/urgent branch, and go on from there, I'll
merge that into my perf/core branch as soon as Linus merges it.