Re: [RFT v2 20/29] memory: omap-gpmc: Return meaningful error codes in... | linux-arm-kernel

[PATCH v2 00/29] *memory: Cleanup, improve and compile test memory drivers · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[RFT v2 01/29] memory: omap-gpmc: Remove unneeded asm/mach-types.h inclusion · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [RFT v2 01/29] memory: omap-gpmc: Remove unneeded asm/mach-types.h inclusion · Krzysztof Kozlowski <krzk@kernel.org> · 2020-08-17
[RFT v2 02/29] memory: omap-gpmc: Remove unused file-scope phys_base and mem_size · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [RFT v2 02/29] memory: omap-gpmc: Remove unused file-scope phys_base and mem_size · Krzysztof Kozlowski <krzk@kernel.org> · 2020-08-17
[PATCH v2 03/29] memory: omap-gpmc: Include <linux/sizes.h> for SZ_16M · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 03/29] memory: omap-gpmc: Include <linux/sizes.h> for SZ_16M · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 04/29] memory: ti-aemif: Rename SS to SSTROBE to avoid name conflicts · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 04/29] memory: ti-aemif: Rename SS to SSTROBE to avoid name conflicts · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 05/29] memory: jz4780-nemc: Do not enable by default on every compile test · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 05/29] memory: jz4780-nemc: Do not enable by default on every compile test · Arnd Bergmann <arnd@arndb.de> · 2020-07-24
Re: [PATCH v2 05/29] memory: jz4780-nemc: Do not enable by default on every compile test · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 06/29] memory: Enable compile testing for most of the drivers · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 06/29] memory: Enable compile testing for most of the drivers · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-27
[PATCH v2 07/29] memory: of: Remove unused headers · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 08/29] memory: of: Remove __func__ in device related messages · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 09/29] memory: of: Correct indentation · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 10/29] memory: of: Remove unneeded extern from function declarations · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 11/29] memory: emif-asm-offsets: Add GPLv2 SPDX license header · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 11/29] memory: emif-asm-offsets: Add GPLv2 SPDX license header · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 12/29] memory: emif: Put constant in comparison on the right side · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 12/29] memory: emif: Put constant in comparison on the right side · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 13/29] memory: emif: Fix whitespace coding style violations · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 13/29] memory: emif: Fix whitespace coding style violations · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 14/29] memory: emif: Silence platform_get_irq() error in driver · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 14/29] memory: emif: Silence platform_get_irq() error in driver · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 15/29] memory: ti-emif-pm: Fix cast to iomem pointer · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 15/29] memory: ti-emif-pm: Fix cast to iomem pointer · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 16/29] memory: renesas-rpc-if: Simplify with PTR_ERR_OR_ZERO · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 16/29] memory: renesas-rpc-if: Simplify with PTR_ERR_OR_ZERO · Krzysztof Kozlowski <krzk@kernel.org> · 2020-08-17
[PATCH v2 17/29] memory: brcmstb_dpfe: Constify the contents of string · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 17/29] memory: brcmstb_dpfe: Constify the contents of string · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 18/29] memory: brcmstb_dpfe: Remove unneeded braces · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 18/29] memory: brcmstb_dpfe: Remove unneeded braces · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 19/29] memory: mtk-smi: Add argument to function pointer definition · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 19/29] memory: mtk-smi: Add argument to function pointer definition · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[RFT v2 20/29] memory: omap-gpmc: Return meaningful error codes in gpmc_cs_set_timings() · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [RFT v2 20/29] memory: omap-gpmc: Return meaningful error codes in gpmc_cs_set_timings() · Krzysztof Kozlowski <krzk@kernel.org> · 2020-08-17
[RFT v2 21/29] memory: omap-gpmc: Remove GPMC_SET_ONE_CD_MAX macro for safety · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [RFT v2 21/29] memory: omap-gpmc: Remove GPMC_SET_ONE_CD_MAX macro for safety · Krzysztof Kozlowski <krzk@kernel.org> · 2020-08-17
[PATCH v2 22/29] memory: omap-gpmc: Fix whitespace issue · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 22/29] memory: omap-gpmc: Fix whitespace issue · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 23/29] memory: pl172: Add GPLv2 SPDX license header · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 23/29] memory: pl172: Add GPLv2 SPDX license header · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 24/29] memory: tegra: tegra210-emc: Fix indentation · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 24/29] memory: tegra: tegra210-emc: Fix indentation · Krzysztof Kozlowski <krzk@kernel.org> · 2020-08-17
[PATCH v2 25/29] MAINTAINERS: Add Krzysztof Kozlowski as maintainer of memory controllers · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 26/29] memory: fsl_ifc: Fix whitespace issues · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 26/29] memory: fsl_ifc: Fix whitespace issues · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 27/29] memory: da8xx-ddrctl: Remove unused 'node' variable · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 27/29] memory: da8xx-ddrctl: Remove unused 'node' variable · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 28/29] memory: Describe the MEMORY Kconfig entry · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
[PATCH v2 29/29] memory: samsung: exynos-srom: Describe the Kconfig entry · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24
Re: [PATCH v2 00/29] *memory: Cleanup, improve and compile test memory drivers · Arnd Bergmann <arnd@arndb.de> · 2020-07-24
Re: [PATCH v2 00/29] *memory: Cleanup, improve and compile test memory drivers · Krzysztof Kozlowski <krzk@kernel.org> · 2020-07-24

Re: [RFT v2 20/29] memory: omap-gpmc: Return meaningful error codes in gpmc_cs_set_timings()

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2020-08-17 18:32:49
Also in: linux-mediatek, linux-omap, linux-samsung-soc, linux-tegra, lkml

On Fri, Jul 24, 2020 at 09:40:29AM +0200, Krzysztof Kozlowski wrote:

The callers of gpmc_cs_set_timings() expect to receive -ERRNO on errors
and they pass further what they have received.

However gpmc_cs_set_timings() was returning -1 (equal to -EPERM) which
does not make sense in this context.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Applied to drivers/memory tree.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help