Re: [PATCH] recordmcount: Fix build failure on non arm64
From: Gregory Herrero <hidden>
Date: 2020-08-10 09:18:58
Also in:
linuxppc-dev, lkml
Hi Christophe, On Mon, Aug 10, 2020 at 08:48:22AM +0000, Christophe Leroy wrote:
Commit ea0eada45632 leads to the following build failure on powerpc: HOSTCC scripts/recordmcount scripts/recordmcount.c: In function 'arm64_is_fake_mcount': scripts/recordmcount.c:440: error: 'R_AARCH64_CALL26' undeclared (first use in this function) scripts/recordmcount.c:440: error: (Each undeclared identifier is reported only once scripts/recordmcount.c:440: error: for each function it appears in.) make[2]: *** [scripts/recordmcount] Error 1 Make sure R_AARCH64_CALL26 is always defined.
Oops, thanks for fixing this. Acked-by: Gregory Herrero <redacted> Greg
quoted hunk ↗ jump to hunk
Fixes: ea0eada45632 ("recordmcount: only record relocation of type R_AARCH64_CALL26 on arm64.") Cc: Gregory Herrero <redacted> Signed-off-by: Christophe Leroy <redacted> --- scripts/recordmcount.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index e59022b3f125..b9c2ee7ab43f 100644 --- a/scripts/recordmcount.c +++ b/scripts/recordmcount.c@@ -42,6 +42,8 @@ #define R_ARM_THM_CALL 10 #define R_ARM_CALL 28 +#define R_AARCH64_CALL26 283 + static int fd_map; /* File descriptor for file being modified. */ static int mmap_failed; /* Boolean flag. */ static char gpfx; /* prefix for global symbol name (sometimes '_') */-- 2.25.0
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel