Re: [PATCH] arm64/fixmap: make notes of fixed_addresses more precisely
From: Catalin Marinas <catalin.marinas@arm.com>
Date: 2020-07-30 11:11:06
On Fri, Jul 10, 2020 at 09:43:22PM +0800, Pingfan Liu wrote:
quoted hunk ↗ jump to hunk
These 'compile-time allocated' memory buffers can occupy more than one page. So improve the note about it. Signed-off-by: Pingfan Liu <redacted> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> To: linux-arm-kernel@lists.infradead.org --- arch/arm64/include/asm/fixmap.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h index f987b8a..318aee1 100644 --- a/arch/arm64/include/asm/fixmap.h +++ b/arch/arm64/include/asm/fixmap.h@@ -29,7 +29,8 @@ * in the boot process. * * These 'compile-time allocated' memory buffers are - * page-sized. Use set_fixmap(idx,phys) to associate + * page-sized (or larger if used with an increment + * higher than 1). Use set_fixmap(idx,phys) to associate * physical memory with fixmap indices.
I don't get this. set_fixmap() only maps a page. Also, what's "increment" in this context? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel