Thread (30 messages) 30 messages, 4 authors, 2020-07-17

Re: [PATCH v2 01/20] coresight: cpu_debug: add module name in Kconfig

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2020-07-15 16:12:26

On Wed, Jul 15, 2020 at 04:56:49PM +0100, Suzuki K Poulose wrote:
Hi Tingwei,

On 07/14/2020 06:48 AM, Tingwei Zhang wrote:
quoted
Provide name of cpu_debug module in Kconfig help section.

Signed-off-by: Tingwei Zhang <redacted>
---
  drivers/hwtracing/coresight/Kconfig | 3 +++
  1 file changed, 3 insertions(+)
diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig
index 02dbb5ca3bcf..4663fd1bbffc 100644
--- a/drivers/hwtracing/coresight/Kconfig
+++ b/drivers/hwtracing/coresight/Kconfig
@@ -110,6 +110,9 @@ config CORESIGHT_CPU_DEBUG
  	  properly, please refer Documentation/trace/coresight/coresight-cpu-debug.rst
  	  for detailed description and the example for usage.
+	  To compile this driver as a module, choose M here: the
+	  module will be called coresight-cpu-debug.
Is this really necessary ? I don't see any value in the "name" part.
Moreover I worry about the mismatch in case someone decides to rename
the file.
If you rename it, you change the Kconfig file.  We have this all over
the Kconfig texts, that shouldn't be something new.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help