Thread (15 messages) 15 messages, 8 authors, 2020-07-29

Re: [PATCH v2 2/3] sched: Cleanup SCHED_THERMAL_PRESSURE kconfig entry

From: Valentin Schneider <hidden>
Date: 2020-07-29 13:29:49
Also in: linux-pm, lkml

On 29/07/20 14:09, Quentin Perret wrote:
quoted hunk ↗ jump to hunk
On Tuesday 28 Jul 2020 at 17:16:57 (+0100), Valentin Schneider wrote:
quoted
We could change the arch Kconfig into

  select SCHED_THERMAL_PRESSURE if CPU_FREQ_THERMAL

but that seems redundant; this dependency is already expressed in
SCHED_THERMAL_PRESSURE's definition. Is there a proper pattern to select
some Kconfig option only if all of its dependencies are met?
How about something like this (totally untested):

---8<---
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 939c4d6bbc2e..2ac74904a3ce 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -46,7 +46,6 @@ config ARM
      select EDAC_ATOMIC_SCRUB
      select GENERIC_ALLOCATOR
      select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY
-	select SCHED_THERMAL_PRESSURE if ARM_CPU_TOPOLOGY
      select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI
      select GENERIC_CLOCKEVENTS_BROADCAST if SMP
      select GENERIC_CPU_AUTOPROBE
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index c403e6f5db86..66dc41fd49f2 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -192,7 +192,6 @@ config ARM64
      select PCI_SYSCALL if PCI
      select POWER_RESET
      select POWER_SUPPLY
-	select SCHED_THERMAL_PRESSURE
      select SPARSE_IRQ
      select SWIOTLB
      select SYSCTL_EXCEPTION_TRACE
diff --git a/init/Kconfig b/init/Kconfig
index 0a97d85568b2..c2e1f3ac527e 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -493,6 +493,7 @@ config HAVE_SCHED_AVG_IRQ

 config SCHED_THERMAL_PRESSURE
      bool
+	default y if ARM64 || ARM_CPU_TOPOLOGY
      depends on SMP
      depends on CPU_FREQ_THERMAL
      help
--->8---
That does seem to do just what I was looking for, thanks!
Thanks,
Quentin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help