Hi Linus,

Thanks for the review

-----Original Message-----
From: Linus Walleij <redacted>
Sent: Friday, July 24, 2020 2:52 PM
To: kernel test robot <redacted>
Cc: Srinivas Neeli <redacted>; Bartosz Golaszewski
[off-list ref]; Michal Simek [off-list ref];
Shubhrajyoti Datta [off-list ref]; Srinivas Goud
[off-list ref]; kbuild-all@lists.01.org; open list:GPIO SUBSYSTEM
[off-list ref]; Linux ARM <linux-arm-
kernel@lists.infradead.org>; linux-kernel@vger.kernel.org; git
[off-list ref]
Subject: Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

On Fri, Jul 24, 2020 at 6:12 AM kernel test robot [off-list ref] wrote:

quoted

   drivers/gpio/gpio-xilinx.c: In function 'xgpio_probe':
   drivers/gpio/gpio-xilinx.c:638:10: error: 'struct gpio_chip' has no member

named 'of_gpio_n_cells'

quoted

     638 |  chip->gc.of_gpio_n_cells = cells;
         |          ^

quoted

quoted

drivers/gpio/gpio-xilinx.c:639:10: error: 'struct gpio_chip' has no

member named 'of_xlate'

quoted

     639 |  chip->gc.of_xlate = xgpio_xlate;
         |          ^

This is probably because your driver needs:

depends on OF_GPIO

in KConfig

I will address in v3.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel