On Fri, Jul 24, 2020 at 01:46:18PM +0530, Anshuman Khandual wrote:

On 07/24/2020 08:38 AM, Kefeng Wang wrote:

quoted

On 2020/7/24 11:04, Kefeng Wang wrote:

quoted

ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined!

ARM64 tegra194-cpufreq driver use cpu_logical_map, export
__cpu_logical_map to fix build issue.

Commit 887d5fc82cb4 ("cpufreq: Add Tegra194 cpufreq driver") which adds
this particular driver is present just on linux-next. But as expected,
the driver does not use __cpu_logical_map directly but instead accesses
it via cpu_logical_map() wrapper. Wondering, how did you even trigger
the modpost error ?

Since the wrapper is a macro, it just expands to __cpu_logical_map[].

quoted

quoted

Reported-by: Hulk Robot <redacted>
Signed-off-by: Kefeng Wang <redacted>
---
  arch/arm64/kernel/setup.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index c793276ec7ad9..3aea05fbb9998 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c

@@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void)

  arch_initcall(reserve_memblock_reserved_regions);
    u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID };
+EXPORT_SYMBOL(__cpu_logical_map);
    void __init setup_arch(char **cmdline_p)
  {

I can see the Tegra cpuidle also using cpu_logical_map(), though it
can't be built as a module, unlike the cpufreq one. I think the patch
makes sense.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel