Re: [PATCH v3,1/2] media: v4l UAPI: add V4L2_BUF_CAP_SUPPORTS_RO_REQUESTS
From: Hans Verkuil <hidden>
Date: 2020-07-23 08:10:43
Also in:
linux-devicetree, linux-media, linux-mediatek, lkml
On 01/07/2020 11:35, Yunfei Dong wrote:
quoted hunk ↗ jump to hunk
This patch adds support for the V4L2_BUF_CAP_SUPPORTS_RO_REQUESTS flag. This flag is used for Read-only(Ro) Request. Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com> --- Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst b/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst index b6d52083707b..7c7451773b8e 100644 --- a/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst +++ b/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst@@ -126,6 +126,7 @@ aborting or finishing any DMA in progress, an implicit .. _V4L2-BUF-CAP-SUPPORTS-REQUESTS: .. _V4L2-BUF-CAP-SUPPORTS-ORPHANED-BUFS: .. _V4L2-BUF-CAP-SUPPORTS-M2M-HOLD-CAPTURE-BUF: +.. _V4L2-BUF-CAP-SUPPORTS-RO-REQUESTS: .. cssclass:: longtable@@ -156,6 +157,9 @@ aborting or finishing any DMA in progress, an implicit - Only valid for stateless decoders. If set, then userspace can set the ``V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF`` flag to hold off on returning the capture buffer until the OUTPUT timestamp changes. + * - ``V4L2_BUF_CAP_SUPPORTS_RO_REQUESTS`` + - 0x00000040 + - This buffer type supports :ref:`requests <media-request-api>`.
This is wrong, it supports *read-only* requests. Also, Documentation/userspace-api/media/mediactl/request-api.rst should mention read-only requests: I think a new section "Read-Only Requests" explaining the purpose and use of such requests would be best. It can be inserted just before the "Example for a Codec Device" at the end. Regards, Hans
Return Value ============
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel