Thread (13 messages) flat view 13 messages, 4 authors, 2020-07-23

Re: [PATCH 2/4] i2c: mediatek: Support DMA mask range over 33-bits

From: Qii Wang <qii.wang@mediatek.com>
Date: 2020-07-23 06:04:43
Also in: linux-devicetree, linux-i2c, linux-mediatek, lkml

On Thu, 2020-07-23 at 09:24 +0800, Yingjoe Chen wrote:
On Wed, 2020-07-22 at 20:31 +0800, Qii Wang wrote:
quoted
Replace 'support_33bits with 'dma_max_support' for DMA mask
operation, and replace 'mtk_i2c_set_4g_mode' with 'upper_32_bits'.
This doesn't explain why we need this patch. How about:

Newer MTK chip support more than 8GB of dram. Replace support_33bits
with more general dma_max_support.
ok, Thanks for your comments.
quoted
Signed-off-by: Qii Wang <qii.wang@mediatek.com>
---
 drivers/i2c/busses/i2c-mt65xx.c | 37 +++++++++++++++++--------------------
 1 file changed, 17 insertions(+), 20 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index e6b984a..e475877 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -209,6 +209,7 @@ struct mtk_i2c_compatible {
 	unsigned char dma_sync: 1;
 	unsigned char ltiming_adjust: 1;
 	unsigned char apdma_sync: 1;
+	unsigned char max_dma_support;
support_33bits is no longer used. Please remove it.

Joe.C
ok.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help