Re: [PATCH 3/3] arm64: stacktrace: Convert to ARCH_STACKWALK
From: Miroslav Benes <mbenes@suse.cz>
Date: 2020-07-17 09:06:35
Also in:
linux-s390, lkml
On Thu, 16 Jul 2020, Mark Brown wrote:
On Thu, Jul 16, 2020 at 01:56:13PM +0200, Miroslav Benes wrote:quoted
On Wed, 15 Jul 2020, Mark Brown wrote:quoted
quoted
-void save_stack_trace(struct stack_trace *trace) -{ - __save_stack_trace(current, trace, 0); + walk_stackframe(task, &frame, consume_entry, cookie); }quoted
just an idea for further improvement (and it might be a matter of taste).Yeah, there's some more stuff that can be done - the reason I'm looking at this code is to do reliable stack trace which is going to require at least some changes to the actual unwinder, this just seemed like a useful block moving things forwards in itself and I particularly wanted feedback on patch 1.
Understood. Reliable stack traces would be an important step for live patching on arm64, so I am looking forward to seeing that. Thanks Miroslav _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel