On 7/9/20 13:23, Daniele Alessandrelli wrote:

Hi Sudeep,

Thanks for your review.

On Wed, 2020-07-08 at 21:34 +0100, Sudeep Holla wrote:

quoted

On Tue, Jun 16, 2020 at 04:56:08PM +0100, Daniele Alessandrelli
wrote:

quoted

From: Paul Murphy <paul.j.murphy@intel.com>

Keem Bay SoC has a ARM trusted firmware-based secure monitor which
acts
as the SCP for the purposes of power management over SCMI.

This driver implements the transport layer for SCMI to function.

Please use the smc transport support in
driver/firmware/arm_scmi/smc.c
for this. You don't need mailbox support for SMC/HVC. Basically you
don't need this driver at all and you have everything you need to
support
what you want.

Let me know if you face issues.

Sorry, we didn't know about the SMC transport support for SCMI. Looks
like it was added only recently, while our driver was already developed
and waiting to be upstreamed.

I agree that we can drop this driver and switch to the SMC transport as
you suggested, but I think we'll have to modify our bootloader SiP
service slightly. Paul, can you elaborate?

Just one question.

In our patch, we pass the shared memory address as the second argument 
of the SiP service, as it means we don't have to hardcode that in our 
firmware. Sudeep, do you know if it was intentional in 
smc_send_message() to leave that out? If we leave it out, we are 
requiring the secure monitor to hardcode the shared memory address.


Regards,
Paul


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel