Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

On Fri, Jul 03, 2020 at 02:17:06PM +0200, Maxime Ripard wrote:

Hi,

On Thu, Jul 02, 2020 at 10:14:32AM +0200, Ondrej Jirman wrote:

quoted

Pinephone has a Goodix GT917S capacitive touchscreen controller on
I2C0 bus. Add support for it.

Signed-off-by: Ondrej Jirman <redacted>
Acked-by: Linus Walleij <redacted>
---
 .../dts/allwinner/sun50i-a64-pinephone.dtsi   | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
index a89425ad3727..5c7386566053 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi

@@ -121,6 +121,25 @@ &ehci1 {
 	status = "okay";
 };
 
+&i2c0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c0_pins>;
+	status = "okay";

I didn't spot this earlier, but the pinctrl properties are already set
in the DTSI. I've removed them while applying the patch.

Ah, right. Thank you very much. :)

regards,
	o.

Thanks!
Maxime

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel