Re: [PATCH] arm: dts: vexpress: Move mcc node back into motherboard node
From: Sudeep Holla <hidden>
Date: 2020-06-04 08:59:38
Also in:
linux-devicetree
On Wed, Jun 03, 2020 at 12:46:14PM -0700, Guenter Roeck wrote:
On Wed, Jun 03, 2020 at 05:22:37PM +0100, Andre Przywara wrote:quoted
Commit d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices out of bus node") moved the "mcc" DT node into the root node, because it does not have any children using "reg" properties, so does violate some dtc checks about "simple-bus" nodes. However this broke the vexpress config-bus code, which walks up the device tree to find the first node with an "arm,vexpress,site" property. This gave the wrong result (matching the root node instead of the motherboard node), so broke the clocks and some other devices for VExpress boards. Move the whole node back into its original position. This re-introduces the dtc warning, but is conceptually the right thing to do. The dtc warning seems to be overzealous here, there are discussions on fixing or relaxing this check instead. Fixes: d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices out of bus node") Signed-off-by: Andre Przywara <andre.przywara@arm.com>Tested-by: Guenter Roeck <linux@roeck-us.net>
Thanks, I have added your Reported-by along with this. By the way, this email seem to have broken the link. Initially thought b4 is getting confused, but checked the lore.kernel.org too to confirm. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel