RE: [PATCH 1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7
From: "Alim Akhtar" <alim.akhtar@samsung.com>
Date: 2020-06-30 15:24:41
Also in:
linux-devicetree, linux-samsung-soc, lkml
Hi Krzysztof,
-----Original Message----- From: Krzysztof Kozlowski <krzk@kernel.org> Sent: 30 June 2020 02:15 To: Rob Herring <robh+dt@kernel.org>; Kukjin Kim <kgene@kernel.org>; Krzysztof Kozlowski [off-list ref]; devicetree@vger.kernel.org;
linux-arm-
quoted hunk ↗ jump to hunk
kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- kernel@vger.kernel.org Cc: Marek Szyprowski <m.szyprowski@samsung.com>; Bartlomiej Zolnierkiewicz [off-list ref]; Sylwester Nawrocki [off-list ref]; Alim Akhtar [off-list ref]; Chanwoo Choi [off-list ref]; Pankaj Dubey [off-list ref] Subject: [PATCH 1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7 Add required interrupts to PWM node on Exynos7. This fixes DT schema warning: pwm@136c0000: 'interrupts' is a required property Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Not tested --- arch/arm64/boot/dts/exynos/exynos7.dtsi | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsib/arch/arm64/boot/dts/exynos/exynos7.dtsi index f590891efe25..523547b3d539 100644--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi@@ -581,6 +581,11 @@ pwm: pwm@136c0000 { compatible = "samsung,exynos4210-pwm"; reg = <0x136c0000 0x100>; + interrupts = <GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 445 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 446 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 447 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 448 IRQ_TYPE_LEVEL_HIGH>;
PWM IRQs are from 449 ~ 453 for PWM[0] ~ PWM[4] on this SoC. 444 ~ 447 are for HSI2C and 448 is for ADC. Please see the exynos7.dtsi Also drivers/pwm/pwm-samsung.c does not uses interrupt at all, still we need interrupts property to be added here?
samsung,pwm-outputs = <0>, <1>, <2>, <3>; #pwm-cells = <3>; clocks = <&clock_peric0 PCLK_PWM>; -- 2.17.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel