On Tue, Jun 30, 2020 at 11:32 AM Andrzej Hajda [off-list ref] wrote:

On 29.06.2020 18:36, Andy Shevchenko wrote:

quoted

On Mon, Jun 29, 2020 at 2:22 PM Andrzej Hajda [off-list ref] wrote:

quoted

/sys/kernel/debug/devices_deferred property contains list of deferred devices.
This list does not contain reason why the driver deferred probe, the patch
improves it.
The natural place to set the reason is dev_err_probe function introduced recently,
ie. if dev_err_probe will be called with -EPROBE_DEFER instead of printk the message
will be attached to deferred device and printed when user read devices_deferred

to a deferred

reads

OK, thx.

quoted

quoted

property.

...

quoted

quoted

         list_for_each_entry(curr, &deferred_probe_pending_list, deferred_probe)
-               seq_printf(s, "%s\n", dev_name(curr->device));
+               seq_printf(s, "%s\t%s", dev_name(curr->device),
+                          curr->device->p->deferred_probe_reason ?: "\n");

Hmm... "\t" will be dangling in the latter case

Hmm, I followed your advice [1] :)

[1]:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1787370.html

Ah, indeed :-)
Okay, as I  said I'm fine with the code. Since it's debugfs, we are fine.

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel