Thread (11 messages) 11 messages, 4 authors, 2020-06-30

Re: [PATCH 2/2] usb: mtu3: fix NULL pointer dereference

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
Date: 2020-06-30 07:29:26
Also in: kernel-janitors, linux-mediatek, linux-usb, lkml

On Mon, 2020-06-29 at 10:00 +0200, Markus Elfring wrote:
quoted
Some pointers are dereferenced before successful checks.
I suggest to reconsider and improve the change description.

* Would a null pointer dereference be possible only with the variables “mep”
  and “mreq” in the implementation of the function “mtu3_gadget_dequeue”?

* How do you think about to adjust any more variable initialisations?
Yes, I'll do it if need, thanks
* Will it become helpful to add the tag “Fixes” to the commit message?
Maybe needn't
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help