RE: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free()
flat view
From: Kirsher, Jeffrey T <hidden>
Date: 2020-06-29 18:59:09
Also in:
linux-devicetree, linux-mediatek, lkml, netdev
-----Original Message----- From: Bartosz Golaszewski <redacted> Sent: Monday, June 29, 2020 05:04 To: Kirsher, Jeffrey T <redacted>; David S . Miller [off-list ref]; Jakub Kicinski [off-list ref]; John Crispin [off-list ref]; Sean Wang [off-list ref]; Mark Lee [off-list ref]; Matthias Brugger [off-list ref]; Heiner Kallweit [off-list ref]; Andrew Lunn [off-list ref]; Florian Fainelli [off-list ref]; Russell King [off-list ref]; Rob Herring [off-list ref]; Frank Rowand [off-list ref] Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; linux-arm- kernel@lists.infradead.org; linux-mediatek@lists.infradead.org; devicetree@vger.kernel.org; Bartosz Golaszewski [off-list ref] Subject: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free() From: Bartosz Golaszewski <redacted> The idea behind devres is that the release callbacks are called if probe fails. As we now check the return value of ixgbe_mii_bus_init(), we can drop the call devm_mdiobus_free() in error path as the release callback will be called automatically. Signed-off-by: Bartosz Golaszewski <redacted>
Acked-by: Jeff Kirsher <redacted>
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel