Re: [PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg_read()
From: Mark Brown <broonie@kernel.org>
Date: 2020-06-26 13:33:10
Also in:
linux-omap, lkml
On Fri, Jun 26, 2020 at 07:57:35AM +0100, Lee Jones wrote:
Until now the aforementioned return value has been ignored.
This is only aforementioned in the subject.
/* Store default strobe info */ ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val); + if (ret) + return ret; +
We should really be logging an error there rather than just returning, that way it's a bit more apparent to someone debugging things what went wrong if there is actually a problem.