Re: [PATCH] scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()'
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2020-06-25 23:10:46
Also in:
kernel-janitors, linux-scsi, lkml
On Thu, Jun 25, 2020 at 10:47:30PM +0200, Christophe JAILLET wrote:
The dev_id used in 'request_irq()' and 'free_irq()' should match.
Use 'info' in both cases.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Christophe JAILLET <redacted>Acked-by: Russell King <redacted> Thanks Christophe.
quoted hunk ↗ jump to hunk
--- V2: update free_irq instead of request_irq in order not to obviously break code --- drivers/scsi/arm/cumana_2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/scsi/arm/cumana_2.c b/drivers/scsi/arm/cumana_2.c index 65691c21f133..29294f0ef8a9 100644 --- a/drivers/scsi/arm/cumana_2.c +++ b/drivers/scsi/arm/cumana_2.c@@ -450,7 +450,7 @@ static int cumanascsi2_probe(struct expansion_card *ec, if (info->info.scsi.dma != NO_DMA) free_dma(info->info.scsi.dma); - free_irq(ec->irq, host); + free_irq(ec->irq, info); out_release: fas216_release(host);-- 2.25.1
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel