Re: [PATCH v3 2/4] spi: bcm63xx-spi: allow building for BMIPS
From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: 2020-06-16 17:31:21
Also in:
linux-spi, lkml
On 6/16/2020 10:25 AM, Mark Brown wrote:
On Tue, Jun 16, 2020 at 10:15:15AM -0700, Florian Fainelli wrote:quoted
On 6/16/2020 10:07 AM, Mark Brown wrote:quoted
quoted
Please do not submit new versions of already applied patches, please submit incremental updates to the existing code. Modifying existing commits creates problems for other users building on top of those commits so it's best practice to only change pubished git commits if absolutely essential.quoted
In Alvaro's defense, you applied the patches despite me requesting that specific changes be made (use the optional reset control API variant).I applied only the two patches that you'd acked, not the reset patches which had problems.
Indeed, sorry for not reading your commit message properly, I believe I request that before, cannot the "applied" response just reply with the patches *applied* and not *all* part of the series?
quoted
Having a FAQ entry about what your expectations as a subsystem maintainer are (ala netdev-FAQ.rst) could save you time along the way.Incremental updates are the default AFAICT?
It really depends if the maintainer is willing to rewrite his tree history, some people do, some people do not, especially if nothing has been submitted to Linus yet. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel