On 11.06.2020 11:48, Anson Huang wrote:

Hi, Daniel

quoted

Subject: Re: [PATCH V4 4/9] pinctrl: imx8mn: Support building as module

Maybe this is obvious but I would really like to see an explanation

of why we are switching from arch_initcall to platform_init.

Commit message act as documentation  for the reviewers.

Yes, I noticed this, and it looks like unnecessary change, and I just replied in
mail that I will change it back to arch_initcall() in order to make sure nothing
changed for built-in config. Below is what I replied in cover-letter mail:

" I will keep the arch_initcall() there in next version patch series, it can make sure
the change does NOT impact built-in config. For module build, the arch_initcall()
will be same as module_init(), user needs to insmod the .ko with correct sequence."

Ok, that's great. Lets try to keep in mind that the commit message should

answer to a simple question: "Why the change is needed" :).


Then, the details about the change should be added.




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel