Re: [PATCH 14/21] KVM: Move x86's version of struct kvm_mmu_memory_cache to common code
From: Marc Zyngier <maz@kernel.org>
Date: 2020-06-11 07:42:40
Also in:
kvm, kvmarm, linux-mips, lkml
Hi Sean, On 2020-06-05 22:38, Sean Christopherson wrote:
quoted hunk ↗ jump to hunk
Move x86's 'struct kvm_mmu_memory_cache' to common code in anticipation of moving the entire x86 implementation code to common KVM and reusing it for arm64 and MIPS. Add a new architecture specific asm/kvm_types.h to control the existence and parameters of the struct. The new header is needed to avoid a chicken-and-egg problem with asm/kvm_host.h as all architectures define instances of the struct in their vCPU structs. Suggested-by: Christoffer Dall <redacted> Signed-off-by: Sean Christopherson <redacted> --- arch/arm64/include/asm/kvm_types.h | 6 ++++++ arch/mips/include/asm/kvm_types.h | 5 +++++ arch/powerpc/include/asm/kvm_types.h | 5 +++++ arch/s390/include/asm/kvm_types.h | 5 +++++ arch/x86/include/asm/kvm_host.h | 13 ------------- arch/x86/include/asm/kvm_types.h | 7 +++++++ include/linux/kvm_types.h | 19 +++++++++++++++++++ 7 files changed, 47 insertions(+), 13 deletions(-) create mode 100644 arch/arm64/include/asm/kvm_types.h create mode 100644 arch/mips/include/asm/kvm_types.h create mode 100644 arch/powerpc/include/asm/kvm_types.h create mode 100644 arch/s390/include/asm/kvm_types.h create mode 100644 arch/x86/include/asm/kvm_types.hdiff --git a/arch/arm64/include/asm/kvm_types.hb/arch/arm64/include/asm/kvm_types.h new file mode 100644 index 000000000000..d0987007d581--- /dev/null +++ b/arch/arm64/include/asm/kvm_types.h@@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_ARM64_KVM_TYPES_H +#define _ASM_ARM64_KVM_TYPES_H + +#endif /* _ASM_ARM64_KVM_TYPES_H */ +diff --git a/arch/mips/include/asm/kvm_types.hb/arch/mips/include/asm/kvm_types.h new file mode 100644 index 000000000000..5efeb32a5926--- /dev/null +++ b/arch/mips/include/asm/kvm_types.h@@ -0,0 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_MIPS_KVM_TYPES_H +#define _ASM_MIPS_KVM_TYPES_H + +#endif /* _ASM_MIPS_KVM_TYPES_H */diff --git a/arch/powerpc/include/asm/kvm_types.hb/arch/powerpc/include/asm/kvm_types.h new file mode 100644 index 000000000000..f627eceaa314--- /dev/null +++ b/arch/powerpc/include/asm/kvm_types.h@@ -0,0 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_POWERPC_KVM_TYPES_H +#define _ASM_POWERPC_KVM_TYPES_H + +#endif /* _ASM_POWERPC_KVM_TYPES_H */diff --git a/arch/s390/include/asm/kvm_types.hb/arch/s390/include/asm/kvm_types.h new file mode 100644 index 000000000000..b66a81f8a354--- /dev/null +++ b/arch/s390/include/asm/kvm_types.h@@ -0,0 +1,5 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_S390_KVM_TYPES_H +#define _ASM_S390_KVM_TYPES_H + +#endif /* _ASM_S390_KVM_TYPES_H */
Instead of carrying an empty include file for at least two of the
architectures
(s390 and Power), how about having it in asm-generic, and updating
arch/$ARCH/include/asm/Kbuild to point to the generic one?
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel