Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
From: Dan Carpenter <hidden>
Date: 2020-06-02 10:14:32
Also in:
kernel-janitors, linux-gpio, lkml
On Sat, May 30, 2020 at 10:49:55PM +0200, Christophe JAILLET wrote:
'pinctrl_unregister()' should not be called to undo
'devm_pinctrl_register_and_init()', it is already handled by the framework.
This simplifies the error handling paths of the probe function.
The 'imx_free_resources()' can be removed as well.
Fixes: a51c158bf0f7 ("pinctrl: imx: use radix trees for groups and functions")
Signed-off-by: Christophe JAILLET <redacted>
---You didn't introduce this but the: ipctl->input_sel_base = of_iomap(np, 0); should be changed to devm_of_iomap(). regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel