Re: [PATCH] ARM: VDSO: Fix incorrect clock_gettime64
From: Robin Murphy <robin.murphy@arm.com>
Date: 2020-05-30 14:51:55
On 2020-04-09 06:05, Jaedon Shin wrote:
__vdso_*() should be removed and fallback used if CNTCVT is not available by cntvct_functional(). __vdso_clock_gettime64 when added previous commit is using the incorrect CNTCVT value in that state. __vdso_clock_gettime64 is also added to remove it's symbol.
Tested-by: Robin Murphy <robin.murphy@arm.com> Turns out this is what was making my RK3288 box virtually unusable since its last couple of updates - it would be nice to get the fix merged and backported ASAP. I suspect it's also the same underlying thing for the Raspberry Pi thread over here: https://lore.kernel.org/linux-arm-kernel/CAK8P3a2Tw2w73ZkK-W6AA9veMK4-miLUx-TL1EuOdP7EdW-AmQ@mail.gmail.com/ (local) Robin.
quoted hunk ↗ jump to hunk
Fixes: 74d06efb9c2f ("ARM: 8932/1: Add clock_gettime64 entry point") Signed-off-by: Jaedon Shin <redacted> --- arch/arm/kernel/vdso.c | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c index e0330a25e1c6..28cfe7bad1bf 100644 --- a/arch/arm/kernel/vdso.c +++ b/arch/arm/kernel/vdso.c@@ -184,6 +184,7 @@ static void __init patch_vdso(void *ehdr) if (!cntvct_ok) { vdso_nullpatch_one(&einfo, "__vdso_gettimeofday"); vdso_nullpatch_one(&einfo, "__vdso_clock_gettime"); + vdso_nullpatch_one(&einfo, "__vdso_clock_gettime64"); } }
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel