Re: [PATCH 05/14] prctl.2: tfix listing order of prctls
From: Michael Kerrisk (man-pages) <hidden>
Date: 2020-05-13 11:31:44
Also in:
linux-arch, linux-man
Hi Dave, On 5/13/20 1:21 PM, Dave Martin wrote:
On Wed, May 13, 2020 at 12:10:53PM +0200, Michael Kerrisk (man-pages) wrote:quoted
Hi Dave, On 5/12/20 6:36 PM, Dave Martin wrote:quoted
The prctl list has historically been sorted by prctl name (ignoring any SET_ or GET_ prefix) to make individual prctls easier to find. Some noise seems to have crept in since. Sort the list back into order. Similarly, reorder the list of prctls specified to return non-zero values on success.This is a good patch. But see my comments on patch 04. I'd prefer a patch like this at the end of a series, rather than in the middle of it.Ack. Ideally we could check the order with a script, but that seemed a step too far.
Quite.
What's the view on having parts of the man pages generated, rather then being distributed ready-built?
I'm not keen (until someone shows me compelling benefits). Splitting things up would make pages harder to edit, and IMO increase the chance for inconsistencies in pages.
If we split prctl.2 up with a fragment per prctl, we could paste the fragments together in the right order with a script.quoted
quoted
Content movement only. No semantic change.And explicitly noting that detail is very helpful to me.Unless of course I'm lying ;) (I'm not, but I won't be offended if you check.)
Actually, with your first two patches, you impressed right out of the gate, so my "I'm gonna blindly trust this guy" needle already switched up pretty high :-). Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel