Re: [PATCH -next] remoteproc/mediatek: fix invalid use of sizeof in scp_ipi_init()
From: Mathieu Poirier <mathieu.poirier@linaro.org>
Date: 2020-05-11 17:45:20
Also in:
kernel-janitors, linux-mediatek, linux-remoteproc
On Sat, 9 May 2020 at 02:38, Wei Yongjun [off-list ref] wrote:
quoted hunk ↗ jump to hunk
sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183") Reported-by: Hulk Robot <redacted> Signed-off-by: Wei Yongjun <redacted> --- drivers/remoteproc/mtk_scp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 2bead57c9cf9..ac13e7b046a6 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c@@ -132,8 +132,8 @@ static int scp_ipi_init(struct mtk_scp *scp) (struct mtk_share_obj __iomem *)(scp->sram_base + recv_offset); scp->send_buf = (struct mtk_share_obj __iomem *)(scp->sram_base + send_offset); - memset_io(scp->recv_buf, 0, sizeof(scp->recv_buf)); - memset_io(scp->send_buf, 0, sizeof(scp->send_buf)); + memset_io(scp->recv_buf, 0, sizeof(*scp->recv_buf)); + memset_io(scp->send_buf, 0, sizeof(*scp->send_buf));
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
return 0;
}
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel