Thread (21 messages) 21 messages, 4 authors, 2020-05-14

Re: [PATCH RFC 1/8] dmaengine: Actions: get rid of bit fields from dma descriptor

From: Amit Tomer <hidden>
Date: 2020-05-11 10:46:39
Also in: dmaengine

Hi

Thanks for the reply.
I'm in favor of getting rid of bitfields due to its not so defined way of
working (and forgive me for using it in first place) but I don't quite like
the current approach.
Because , its less readable the way we are writing to those different fields ?
But this can be made more verbose by adding some comments around .
Rather I'd like to have custom bitmasks (S900/S700/S500?) for writing to those
fields.
I think S900 and S500 are same as pointed out by Cristian. and I didn't get by
creating custom bitmasks for it ?

Did you mean function like:

lli->hw[OWL_DMADESC_FLEN]= llc_hw_FLEN(len, FCNT_VALUE, FCNT_SHIFT);

Thanks
-Amit

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help