czw., 28 maj 2020 o 15:48 Mark Brown [off-list ref] napisał(a):

On Thu, May 28, 2020 at 03:32:40PM +0200, Bartosz Golaszewski wrote:

quoted

czw., 28 maj 2020 o 15:29 Mark Brown [off-list ref] napisał(a):

quoted

quoted

Why macros and not static inlines?

quoted

The existing regmap_update_bits_*() helpers are macros too, so I tried
to stay consistent. Any reason why they are macros and not static
inlines? If there's none, then why not convert them too? Otherwise
we'd have a static inline expanding a macro which in turn is calling a
function (regmap_update_bits_base()).

Not really, I think it was just that they're argument tables.  It'd be
good to convert them.

Ok. So I'm seeing there are a lot of macros in regmap.h that could
become static inlines but given the amount of regmap users: how about
we do it separately and in the meantime I'll just modify this series
to use static inlines?

Bartosz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel