Thread (22 messages) 22 messages, 3 authors, 2020-05-15

Re: [PATCH v3 0/7] firmware: smccc: Add basic SMCCC v1.2 + ARCH_SOC_ID support

From: Sudeep Holla <hidden>
Date: 2020-05-15 09:18:24
Also in: lkml

On Fri, May 15, 2020 at 09:50:32AM +0200, Etienne Carriere wrote:
quoted
From: Sudeep Holla <redacted>

Hi,

This patch series adds support for SMCCCv1.2 ARCH_SOC_ID.
This doesn't add other changes added in SMCCC v1.2 yet. They will
follow these soon along with its first user SPCI/PSA-FF.

This is tested using upstream TF-A + the patch[2] fixing the original
implementation there.


v1[0]->v2[1]:
- Incorporated comments from Steven Price in patch 5/5
- Fixed build for CONFIG_PSCI_FW=n on some arm32 platforms
- Added Steven Price's review tags

v2[1]->v3:
- Incorporated additional comments from Steven Price in patch 5/5
 and added his review tags
- Refactored SMCCC code from PSCI and moved it under
 drivers/firmware/smccc/smccc.c
- Also moved soc_id.c under drivers/firmware/smccc

Regards,
Sudeep
Hello Sudeep,

In case it helps. I have successfully tested the 7 patches series
on some platforms, playing a bit with few configurations.
Qemu emulator for arm64/cortex-a57 with TF-A (v2.x) as secure firmware.
Qemu emulator for arm/cortex-a15. OP-TEE (v3.x) as secure firmware.
A stm32mp15 device (arm/cortex-a7), tested both TF-A (v2.x) and
OP-TEE (3.7.0, 3.9.0-rc) as runtime secure firmware.

Helper functions arm_smccc_1_1_get_conduit()/arm_smccc_1_1_invoke() 
works as expected AFAICT. No regression seen with older secure
firmwares.

For the patches 1 to 6, as I poorly tested [v3,7/7] soc ids,
based on tag next-20200505 [1]:
Tested-by: Etienne Carriere <redacted>
Reviewed-by: Etienne Carriere <redacted>

For [v3,7/7] firmware: smccc: Add ARCH_SOC_ID support
Acked-by: Etienne Carriere <redacted>

[1] 7def1ef0f72c ("Add linux-next specific files for 20200505")
Thanks for review and testing Etienne. Much appreciated!

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help