Re: [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board
From: dillon min <hidden>
Date: 2020-05-14 09:18:23
Also in:
dri-devel, linux-clk, linux-devicetree, lkml
Hi, Linus, thanks for reviewing. On Thu, May 14, 2020 at 4:24 PM Linus Walleij [off-list ref] wrote:
On Tue, May 12, 2020 at 9:04 AM [off-list ref] wrote:quoted
From: dillon min <redacted> Enable the ltdc & ili9341 on stm32429-disco board. Signed-off-by: dillon min <redacted>This mostly looks good but...quoted
+&spi5 { + status = "okay"; + pinctrl-0 = <&spi5_pins>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; + dmas = <&dma2 3 2 0x400 0x0>, + <&dma2 4 2 0x400 0x0>; + dma-names = "rx", "tx";These DMA assignments seem to be SoC things and should rather be in the DTS(I) file where &spi5 is defined, right? stm32f429.dtsi I suppose? It is likely the same no matter which device is using spi5. Yours, Linus Walleij
Yes, the dma assignments can be moved to stm32f429.dtsi file. i will change it. thanks. best regards. dillon, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel