Re: [PATCH v3 02/25] drm: core: fix common struct sg_table related issues
From: Marek Szyprowski <m.szyprowski@samsung.com>
Date: 2020-05-12 09:05:16
Also in:
dri-devel, linux-iommu, lkml
Hi Christoph, On 08.05.2020 09:16, Christoph Hellwig wrote:
On Fri, May 08, 2020 at 09:12:13AM +0200, Marek Szyprowski wrote:quoted
Then we would just need one more helper to construct scatterlist, as the above two are read-only don't allow to modify scatterlist: #define for_each_sgtable_sg(sgt, sg, i) \ for_each_sg(sgt->sgl, sg, sgt->orig_nents, i) With the above 3 helpers we can probably get rid of all instances of sg_table->{nents,orig_nents} from the DRM code. I will prepare patches soon.Sounds great, thanks!
It turned out that the 4th helper (for_each_sgtable_dma_sg) was needed as some drivers makes use of the larger than the PAGE_SIZE unit for DMA mapped pages. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel