Re: [PATCH v4 02/14] arm: add support for folded p4d page tables
From: Mike Rapoport <hidden>
Date: 2020-05-11 14:16:38
Also in:
kvmarm, linux-arch, linux-mm, linux-sh, linuxppc-dev, lkml
Hi Marek, On Mon, May 11, 2020 at 08:36:41AM +0200, Marek Szyprowski wrote:
Hi Mike, On 08.05.2020 19:42, Mike Rapoport wrote:quoted
On Fri, May 08, 2020 at 08:53:27AM +0200, Marek Szyprowski wrote:quoted
On 07.05.2020 18:11, Mike Rapoport wrote:quoted
On Thu, May 07, 2020 at 02:16:56PM +0200, Marek Szyprowski wrote:quoted
On 14.04.2020 17:34, Mike Rapoport wrote:quoted
From: Mike Rapoport <redacted> Implement primitives necessary for the 4th level folding, add walks of p4d level where appropriate, and remove __ARCH_USE_5LEVEL_HACK. Signed-off-by: Mike Rapoport <redacted>Can you please try the patch below:diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index 963b5284d284..f86b3d17928e 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c@@ -571,7 +571,7 @@ static inline void section_update(unsigned long addr, pmdval_t mask, { pmd_t *pmd; - pmd = pmd_off_k(addr); + pmd = pmd_offset(pud_offset(p4d_offset(pgd_offset(mm, addr), addr), addr), addr); #ifdef CONFIG_ARM_LPAE pmd[0] = __pmd((pmd_val(pmd[0]) & mask) | prot);This fixes kexec issue! Thanks! Feel free to add: Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Fixes: 218f1c390557 ("arm: add support for folded p4d page tables") Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Thanks for testing! The patch is still in mmotm tree, so I don't think "Fixes" apply. Andrew, would you like me to send the fix as a formal patch or will pick it up as a fixup?
Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
-- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel