Thread (7 messages) 7 messages, 2 authors, 2020-05-11

Re: [PATCH v3 2/2] soc: ti: add k3 platforms chipid module driver

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: 2020-05-11 11:11:30
Also in: linux-devicetree, lkml

Hi Arnd,

On 09/05/2020 01:17, Arnd Bergmann wrote:
On Fri, May 8, 2020 at 12:01 PM Grygorii Strashko
[off-list ref] wrote:
quoted
+static int __init k3_chipinfo_init(void)
+{
+       struct soc_device_attribute *soc_dev_attr;
+       struct soc_device *soc_dev;
+       struct device_node *node;
+       struct regmap *regmap;
+       u32 partno_id;
+       u32 variant;
+       u32 jtag_id;
+       u32 mfg;
+       int ret;
+
+       node = of_find_compatible_node(NULL, NULL, "ti,am654-chipid");
+       if (!node)
+               return -ENODEV;
This will fail the initcall and print a warning when the kernel runs on any
other SoC. Would it be possible to just make this a platform_driver?

If not, I think you should silently return success when the device
node is absent.
Thank you for your report.
Can' make it platform drv., as te SoC info need to be accessible by divers early.
I'll fix it to return success.

-- 
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help