Re: [PATCH v3 1/4] dt-bindings: rockchip-rga: Add PX30 compatible

Hi,

On Thu 30 Apr 20, 23:24, Johan Jonker wrote:

Hi Paul,

quoted

Add a new compatible for the PX30 Rockchip SoC, which also features
a RGA block. It is compatible with the RK3288 RGA block.

Signed-off-by: Paul Kocialkowski <redacted>
---
 Documentation/devicetree/bindings/media/rockchip-rga.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.yaml b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
index dd645ddccb07..740586299da9 100644
--- a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip-rga.yaml

@@ -23,6 +23,9 @@ properties:

quoted

       - items:
           - const: rockchip,rk3228-rga
           - const: rockchip,rk3288-rga
+      - items:
+          - const: rockchip,px30-rga
+          - const: rockchip,rk3288-rga

Use enum.

      - items:
          - enum:
            - rockchip,px30-rga
            - rockchip,rk3228-rga
          - const: rockchip,rk3288-rga

Are you sure about this? The rk3228 above does it as I did it and other examples
like allwinner,sun4i-a10-csi.yaml appear to be doing the same too.

The case with rockchip,rk3288-rga alone already seems covered.

Cheers,

Paul

quoted

 
   reg:
     maxItems: 1
-- 
2.26.0

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com