Re: [PATCH v4 2/2] serial: uartps: Add TACTIVE check in cdns_uart_tx_empty function
From: Maarten Brock <hidden>
Date: 2020-03-21 10:07:32
Also in:
linux-serial
From: Maarten Brock <hidden>
Date: 2020-03-21 10:07:32
Also in:
linux-serial
On 2020-03-19 10:44, Shubhrajyoti Datta wrote:
From: Raviteja Narayanam <redacted> Make sure that all bytes are transmitted out of Uart by monitoring CDNS_UART_SR_TACTIVE bit as well. Signed-off-by: Raviteja Narayanam <redacted> Signed-off-by: Shubhrajyoti Datta <redacted> --- drivers/tty/serial/xilinx_uartps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/tty/serial/xilinx_uartps.cb/drivers/tty/serial/xilinx_uartps.c index 662b8ab..38cb76a9 100644--- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c@@ -663,8 +663,8 @@ static unsigned int cdns_uart_tx_empty(structuart_port *port) unsigned int status; status = readl(port->membase + CDNS_UART_SR) & - CDNS_UART_SR_TXEMPTY; - return status ? TIOCSER_TEMT : 0; + (CDNS_UART_SR_TXEMPTY | CDNS_UART_SR_TACTIVE); + return (status == CDNS_UART_SR_TXEMPTY) ? TIOCSER_TEMT : 0; } /**
Acked-by: Maarten Brock <redacted> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel